Question

1. He kept all her letters.
2. He is keeping all her letters.
3. He has kept all her letters for 10 years.
4. He has been keeping all her letters till now.
(Are they all grammatical?)

Answer 1

I'd use "until" in that last sentence, but otherwise, they're all fine.